Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelteserver errors for open brackets ( #391

Open
maximyurevich opened this issue Sep 13, 2023 · 6 comments
Open

svelteserver errors for open brackets ( #391

maximyurevich opened this issue Sep 13, 2023 · 6 comments

Comments

@maximyurevich
Copy link
Contributor

Screenshot from 2023-09-13 11-24-16
Screenshot from 2023-09-13 11-23-43

@andlrc
Copy link
Contributor

andlrc commented Sep 13, 2023

The svelte LSP server is for some reason sending a list of numbers instead of a string in the label property:

/**
 * Represents the signature of something callable. A signature
 * can have a label, like a function-name, a doc-comment, and
 * a set of parameters.
 */
export interface [SignatureInformation](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureInformation) {
	/**
	 * The label of this signature. Will be shown in
	 * the UI.
	 */
	label: string;

	/**
	 * The human-readable doc-comment of this signature. Will be shown
	 * in the UI but can be omitted.
	 */
	documentation?: string | [MarkupContent](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#markupContentInnerDefinition);

	/**
	 * The parameters of this signature.
	 */
	parameters?: [ParameterInformation](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#parameterInformation)[];

	/**
	 * The index of the active parameter.
	 *
	 * If provided, this is used in place of `SignatureHelp.activeParameter`.
	 *
	 * @since 3.16.0
	 */
	activeParameter?: [uinteger](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#uinteger);
}

See: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureInformation

Can you enable debugging for the server and send the log? See :h lsp-debug for how to do this.

I'm curious as to why the svelte server is sending the list of numbers.

@maximyurevich
Copy link
Contributor Author

maximyurevich commented Sep 13, 2023

The svelte LSP server is for some reason sending a list of numbers instead of a string in the label property:

/**
 * Represents the signature of something callable. A signature
 * can have a label, like a function-name, a doc-comment, and
 * a set of parameters.
 */
export interface [SignatureInformation](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureInformation) {
	/**
	 * The label of this signature. Will be shown in
	 * the UI.
	 */
	label: string;

	/**
	 * The human-readable doc-comment of this signature. Will be shown
	 * in the UI but can be omitted.
	 */
	documentation?: string | [MarkupContent](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#markupContentInnerDefinition);

	/**
	 * The parameters of this signature.
	 */
	parameters?: [ParameterInformation](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#parameterInformation)[];

	/**
	 * The index of the active parameter.
	 *
	 * If provided, this is used in place of `SignatureHelp.activeParameter`.
	 *
	 * @since 3.16.0
	 */
	activeParameter?: [uinteger](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#uinteger);
}

See: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#signatureInformation

Can you enable debugging for the server and send the log? See :h lsp-debug for how to do this.

I'm curious as to why the svelte server is sending the list of numbers.

I don't know why it's named lsp-tsserver.log, but there's a mention of svelte
lsp-tsserver.log

@andlrc
Copy link
Contributor

andlrc commented Sep 13, 2023

@maximyurevich can you try out #392 I havn't had a change to test it myself, as I don't have a svelte LSP server installed.

@maximyurevich
Copy link
Contributor Author

@maximyurevich can you try out #392 I havn't had a change to test it myself, as I don't have a svelte LSP server installed.

Tomorrow

@maximyurevich
Copy link
Contributor Author

@maximyurevich can you try out #392 I havn't had a change to test it myself, as I don't have a svelte LSP server installed.

works fine

Peek.2023-09-14.21-47.mp4

@maximyurevich
Copy link
Contributor Author

@maximyurevich can you try out #392 I havn't had a change to test it myself, as I don't have a svelte LSP server installed.

Why this commit in draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants