feat: support file upload in router #758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedraumcosta
force-pushed
the
file-upload
branch
2 times, most recently
from
11cd5f0
to
ce32b11
Compare
pedraumcosta
force-pushed
the
file-upload
branch
from
b9aa48c
to
88e5ae1
Compare
pedraumcosta
force-pushed
the
file-upload
branch
from
88e5ae1
to
c41faf8
Compare
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes possible to support a file upload according to spec:
https://github.com/jaydenseric/graphql-multipart-request-spec
With this PR merged to main and released we can discuss and work on PR to support the feature in cosmo router:
wundergraph/cosmo#652
Basically, this PR makes possible to pass a temporary file information stored in file system to structures responsible for graphql resolve operation. Additionally, introduces a method in nethttpclient.go to actually perform the multipart http request.