Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support file upload in router #772

Merged
merged 35 commits into from
Jun 26, 2024

Conversation

pedraumcosta
Copy link
Contributor

Motivation and Context

This PR makes possible to support a file upload according to spec:

https://github.com/jaydenseric/graphql-multipart-request-spec

This PR depends on this PR from graphql-go-tools:

wundergraph/graphql-go-tools#758

This PR parse multiform part http requests with files, saves in the file system and passed the file information along the graphql tools library to be forwarded to a subgraph that supports files uploads. In order to make tests possible, I added file uploads operations to the demo employee subgraph and some enhanced methods to test infrastructure.

TODO

@github-actions github-actions bot added the router label May 8, 2024
@pedraumcosta pedraumcosta force-pushed the file-upload branch 2 times, most recently from 069b025 to baae770 Compare May 8, 2024 16:05
Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Copy link

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 14, 2024
@alexandra-c
Copy link
Contributor

Any news about when this will get merged or if it will be? We are also using multipart request on several projects and waiting for this fix. Thank you!

@Aenimus
Copy link
Member

Aenimus commented Jun 14, 2024

Hi @pedraumcosta

Please could you pull in the latest main and then run make go-sync-workspace from root?

@Aenimus
Copy link
Member

Aenimus commented Jun 14, 2024

Hi @alexandra-c

There is no time box for pull requests such as this. Please understand that our capacity is limited, and while we strive to review PRs as soon as possible, our priorities are dictated by our existing customers.

Thank you for your patience.

@github-actions github-actions bot removed the Stale label Jun 15, 2024
@pedraumcosta
Copy link
Contributor Author

Hi @pedraumcosta

Please could you pull in the latest main and then run make go-sync-workspace from root?

Hey @Aenimus !!! I just rebased, sorry for the delay.

router-tests/integration_test.go Outdated Show resolved Hide resolved
router-tests/integration_test.go Outdated Show resolved Hide resolved
router-tests/testenv/testenv.go Outdated Show resolved Hide resolved
router/core/context.go Show resolved Hide resolved
router/core/graphql_prehandler.go Show resolved Hide resolved
router/core/graphql_prehandler.go Outdated Show resolved Hide resolved
router-tests/file_upload_test.go Show resolved Hide resolved
router-tests/file_upload_test.go Outdated Show resolved Hide resolved
router-tests/file_upload_test.go Outdated Show resolved Hide resolved
router/core/graphql_prehandler.go Outdated Show resolved Hide resolved
router/core/router.go Outdated Show resolved Hide resolved
@thisisnithin thisisnithin enabled auto-merge (squash) June 26, 2024 11:02
Copy link
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnithin thisisnithin merged commit d1cbc11 into wundergraph:main Jun 26, 2024
11 checks passed
@StarpTech
Copy link
Contributor

Please don't forget to extend the docs and a section about how to use this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants