-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support file upload in router #772
Conversation
069b025
to
baae770
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Any news about when this will get merged or if it will be? We are also using multipart request on several projects and waiting for this fix. Thank you! |
Please could you pull in the latest main and then run |
Hi @alexandra-c There is no time box for pull requests such as this. Please understand that our capacity is limited, and while we strive to review PRs as soon as possible, our priorities are dictated by our existing customers. Thank you for your patience. |
be14190
to
6001cbc
Compare
Hey @Aenimus !!! I just rebased, sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please don't forget to extend the docs and a section about how to use this feature. |
Motivation and Context
This PR makes possible to support a file upload according to spec:
https://github.com/jaydenseric/graphql-multipart-request-spec
This PR depends on this PR from graphql-go-tools:
wundergraph/graphql-go-tools#758
This PR parse multiform part http requests with files, saves in the file system and passed the file information along the graphql tools library to be forwarded to a subgraph that supports files uploads. In order to make tests possible, I added file uploads operations to the demo employee subgraph and some enhanced methods to test infrastructure.
TODO