Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Worker is dead term #229

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Worker is dead term #229

merged 2 commits into from
Nov 26, 2024

Commits on Nov 25, 2024

  1. ✏️ Fix spelling

    @pboling
    pboling committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    61c91b0 View commit details
    Browse the repository at this point in the history

  2. 🐛 Queue always nil in default_retries_exhausted_message 

    - worker is no longer used in most scenarios
  - See: https://github.com/sidekiq/sidekiq/wiki/Best-Practices#4-use-precise-terminology
- keys are string, symbol lookups fail
- Add test
    @pboling
    pboling committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    d129614 View commit details
    Browse the repository at this point in the history