Worker is dead term #229
Merged
Worker is dead term #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- worker is no longer used in most scenarios - See: https://github.com/sidekiq/sidekiq/wiki/Best-Practices#4-use-precise-terminology - keys are string, symbol lookups fail - Add test
|
It's worth noting that this gem uses the worker term (as sidekiq/sidekiq#4971 (comment) |
wspurgin
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks @pboling - much appreciated. Agreed that Worker is a dead-term in Sidekiq and moving this over to Job while still supporting older versions of Sidekiq is certainly a spring-cleaning project worth undertaking.
Thanks again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Queue always nil in default_retries_exhausted_message