Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce SmallVector and SmallString usage #7610

Open
wants to merge 58 commits into
base: 2027
Choose a base branch
from
Open

Reduce SmallVector and SmallString usage #7610

wants to merge 58 commits into from
+707 −1,227

Conversation

PeterJohnson
Copy link
Member

@PeterJohnson PeterJohnson commented Dec 31, 2024 •
edited
Loading

Still WIP

@PeterJohnson PeterJohnson requested review from a team as code owners December 31, 2024 03:49
@github-actions github-actions bot added component: ntcore NetworkTables library component: cscore CameraServer library component: wpiutil WPI utility library component: wpinet WPI networking library 2027 2027 target component: glass Glass app and backend labels Dec 31, 2024
KangarooKoala
KangarooKoala reviewed Jan 1, 2025
View reviewed changes
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, what's the reason for reducing SmallVector usage? Trying to shift towards using standard library stuff instead of LLVM stuff?

wpiutil/src/main/native/thirdparty/llvm/include/wpi/StringExtras.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/thirdparty/llvm/include/wpi/StringExtras.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/thirdparty/llvm/include/wpi/StringExtras.h Outdated Show resolved Hide resolved
wpiutil/src/main/native/thirdparty/llvm/include/wpi/StringExtras.h Outdated Show resolved Hide resolved
@PeterJohnson
Copy link
Member Author

Yes, essentially, the goal is to use more standard library stuff unless SmallVector provides an obvious performance benefit (e.g. "hot" paths).

@PeterJohnson PeterJohnson requested a review from a team as a code owner January 1, 2025 22:34
@github-actions github-actions bot added component: hal Hardware Abstraction Layer component: datalogtool DataLog Tool component: sysid SysId app labels Jan 1, 2025
@PeterJohnson PeterJohnson requested a review from a team as a code owner January 2, 2025 05:16
@github-actions github-actions bot added component: wpilibc WPILib C++ component: teamnumbersetter roboRIO Team Number Setter labels Jan 2, 2025
@PeterJohnson
[ntcore] LocalStorage: Remove SmallString
3e5b2e7
@PeterJohnson
[ntcore] Remove SmallVector and SmallString from most places
3c8a83f
@PeterJohnson
Add missing include
8f7354e
@PeterJohnson
Fix windows
b8d2f1c
@PeterJohnson
Fix systemcore HAL
67dab07
@PeterJohnson
[wpilibc] Reduce SmallVector usage
1f262cd
@PeterJohnson
[wpilibc] Reduce SmallString usage
f76af08
@PeterJohnson
Header cleanup
99b7ee3
@PeterJohnson
[wpinet] hostname: Remove SmallVector version
5fad0bf
@PeterJohnson
[wpinet] Process: Remove SmallVector
8794373
@PeterJohnson
[wpinet] MulticastServiceAnnouncer: Remove SmallVector
2f938a7
@PeterJohnson
[wpinet] JNI: Remove SmallVector use
ccd2366
@PeterJohnson
More removals
73f8bc3
@PeterJohnson
Remove from sha1
c61fa08
@PeterJohnson
Remove from base64
5672594
@PeterJohnson
Simplify base64 vector decode
166d840
@PeterJohnson
windows service resolver
5c6f891
@PeterJohnson
More cleanup
ece439c
@PeterJohnson
Remove from SimpleBufferPool
989024b
@PeterJohnson
Missing includes
6078ffd
@PeterJohnson
Fix one more SimpleBufferPool use case
3272b8c
@PeterJohnson
CameraServer: Remove SmallString
1d85839
@PeterJohnson
Use std::string in more places
5b0bc50
@PeterJohnson
Fix athena
16c6860
@PeterJohnson
MulticastServiceResolver: Remove SmallString
72a4044
@PeterJohnson
DynamicStruct: Don't use SmallString
5d812a1
@PeterJohnson
[wpiutil] DataLog: use format instead of SmallString
2996f5a
@PeterJohnson
[wpiutil] Convert a couple of use cases to std::string
3ac4f8d
@PeterJohnson
Consistency
621a94a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangarooKoala KangarooKoala KangarooKoala left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2027 2027 target component: cscore CameraServer library component: datalogtool DataLog Tool component: glass Glass app and backend component: hal Hardware Abstraction Layer component: ntcore NetworkTables library component: sysid SysId app component: teamnumbersetter roboRIO Team Number Setter component: wpilibc WPILib C++ component: wpinet WPI networking library component: wpiutil WPI utility library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterJohnson @KangarooKoala