Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a very simple upgrade dialog #658

Merged
merged 6 commits into from
Feb 9, 2023
Merged

a very simple upgrade dialog #658

merged 6 commits into from
Feb 9, 2023

Conversation

aw-was-here
Copy link
Collaborator

@aw-was-here aw-was-here commented Feb 9, 2023

at least a something closer to #648

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 9, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 5.10%.

Quality metrics Before After Change
Complexity 8.49 ⭐ 7.75 ⭐ -0.74 👍
Method Length 94.38 🙂 86.35 🙂 -8.03 👍
Working memory 8.58 🙂 7.64 🙂 -0.94 👍
Quality 58.69% 🙂 63.79% 🙂 5.10% 👍
Other metrics Before After Change
Lines 252 412 160
Changed files Quality Before Quality After Quality Change
nowplaying/upgrade.py 58.69% 🙂 63.79% 🙂 5.10% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nowplaying/upgrade.py UpgradeConfig.upgrade 16 🙂 322 ⛔ 11 😞 35.78% 😞 Try splitting into smaller methods. Extract out complex expressions
nowplaying/upgrade.py UpgradeTemplates.setup_templates 12 🙂 188 😞 9 🙂 49.90% 😞 Try splitting into smaller methods
nowplaying/upgrade.py UpgradeBinary.get_versions 15 🙂 139 😞 8 🙂 54.33% 🙂 Try splitting into smaller methods
nowplaying/upgrade.py Version.__lt__ 11 🙂 183 😞 5 ⭐ 60.80% 🙂 Try splitting into smaller methods
nowplaying/upgrade.py UpgradeTemplates.__init__ 4 ⭐ 144 😞 8 🙂 63.85% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@aw-was-here aw-was-here merged commit 9becd96 into main Feb 9, 2023
@aw-was-here aw-was-here deleted the upgrade branch February 9, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant