a very simple upgrade dialog (Sourcery refactored) #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-89
to
+106
| if self.chunk.get('rc') and other.chunk.get('rc'): | ||
| if self.chunk.get('rc') != other.chunk.get('rc'): | ||
| return self.chunk.get('rc') < other.chunk.get('rc') | ||
| if ( | ||
| self.chunk.get('rc') | ||
| and other.chunk.get('rc') | ||
| and self.chunk.get('rc') != other.chunk.get('rc') | ||
| ): | ||
| return self.chunk.get('rc') < other.chunk.get('rc') | ||
|
|
||
| # but commitnum > no commitnum at this point | ||
| if self.chunk.get('commitnum') and not other.chunk.get('commitnum'): | ||
| return False | ||
|
|
||
| if self.chunk.get('commitnum') and other.chunk.get('commitnum'): | ||
| if self.chunk.get('commitnum') != other.chunk.get('commitnum'): | ||
| return self.chunk.get('commitnum') < other.chunk.get( | ||
| 'commitnum') | ||
| if ( | ||
| self.chunk.get('commitnum') | ||
| and other.chunk.get('commitnum') | ||
| and self.chunk.get('commitnum') != other.chunk.get('commitnum') | ||
| ): | ||
| return self.chunk.get('commitnum') < other.chunk.get( | ||
| 'commitnum') |
There was a problem hiding this comment.
Function Version.__lt__ refactored with the following changes:
- Merge nested if conditions [×2] (
merge-nested-ifs)
Comment on lines
-136
to
+144
| else: | ||
| if self.stable < tagname: | ||
| self.stable = tagname | ||
| self.stabledata = rel | ||
| elif self.stable < tagname: | ||
| self.stable = tagname | ||
| self.stabledata = rel |
There was a problem hiding this comment.
Function UpgradeBinary.get_versions refactored with the following changes:
- Merge else clause's nested if statement into elif (
merge-else-if-into-elif)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.50%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #658 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
upgradebranch, then run:Help us improve this pull request!