-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add platform target properties to compiler. #18378
Open
vankop
wants to merge
5
commits into
main
Choose a base branch
from
feat-platform-target-properties-in-compiler
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e11fb12
add platform target properties to compiler.
vankop 8510a6d
add test
vankop 3a498e7
fix namings
vankop 31ddbd2
Merge branch 'main' into feat-platform-target-properties-in-compiler
vankop ba6ace7
Merge branch 'main' into feat-platform-target-properties-in-compiler
vankop File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
MIT License http://www.opensource.org/licenses/mit-license.php | ||
Authors Ivan Kopeykin @vankop | ||
*/ | ||
|
||
"use strict"; | ||
|
||
/** @typedef {import("./Compiler")} Compiler */ | ||
/** @typedef {import("./config/target").PlatformTargetProperties} PlatformTargetProperties */ | ||
|
||
/** | ||
* Should be used only for "target === false" or | ||
* when you want to overwrite platform target properties | ||
*/ | ||
class PlatformPlugin { | ||
/** | ||
* @param {Partial<PlatformTargetProperties>} platform target properties | ||
*/ | ||
constructor(platform) { | ||
/** @type {Partial<PlatformTargetProperties>} */ | ||
this.platform = platform; | ||
} | ||
|
||
/** | ||
* Apply the plugin | ||
* @param {Compiler} compiler the compiler instance | ||
* @returns {void} | ||
*/ | ||
apply(compiler) { | ||
compiler.hooks.environment.tap("PlatformPlugin", () => { | ||
compiler.platform = { | ||
...compiler.platform, | ||
...this.platform | ||
}; | ||
}); | ||
} | ||
} | ||
|
||
module.exports = PlatformPlugin; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's return all
targetProperties
and set them here https://github.com/webpack/webpack/pull/18378/files#diff-7979ef8b26e853797876ef65fffd2669a8c088f6ae7853028ed4b876f9f0be65R85, I imagine that in the future we may need more properties of our targetsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest of the target properties related to environment, they are accessible in
output.environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webpack/lib/config/defaults.js
Line 1099 in 31ddbd2