add platform target properties to compiler. #18378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
add 2 methods `compiler.getPlatformTargetInfo` and `compiler.setPlatformTargetInfo` to allow get and set platform target properties. by default resolve this properties from target option.
vankop
force-pushed
the
feat-platform-target-properties-in-compiler
branch
from
b83e17e
to
e11fb12
Compare
|
could we add this in another PR? @alexander-akait |
| node: targetProperties.node, | ||
| nwjs: targetProperties.nwjs, | ||
| electron: targetProperties.electron | ||
| }; |
There was a problem hiding this comment.
Let's return all targetProperties and set them here https://github.com/webpack/webpack/pull/18378/files#diff-7979ef8b26e853797876ef65fffd2669a8c088f6ae7853028ed4b876f9f0be65R85, I imagine that in the future we may need more properties of our targets
There was a problem hiding this comment.
rest of the target properties related to environment, they are accessible in output.environment
There was a problem hiding this comment.
webpack/lib/config/defaults.js
Line 1099 in 31ddbd2
|
@vankop Let's rebase |
# Conflicts: # lib/config/defaults.js # lib/webpack.js # types.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
add 2 methods
compiler.getPlatformTargetInfoandcompiler.setPlatformTargetInfoto allow get and set platform target properties. by default resolve this properties from target option.Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
compiler.getPlatformTargetInfoandcompiler.setPlatformTargetInfo. Also newPlatformPluginthat allow to change platform options, e.g.new PlatformPlugin({ node: true })