-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dynamic clientId Initialization #61
base: main
Are you sure you want to change the base?
Conversation
Thanks @zuhno this is a brilliant work, and im really happy about this PR 💪 it looks really good as i checked on surface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im going through the code little bit
@kasvith Please let me know if there are any parts that need to be revised. |
Sure, i didnt have much time lately to focus on the project |
refactor: applied early return to 'isClientIdValid'
src/states/index.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets rename this as src/store.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasvith
yes, the changes have been made as follows:
- identified the similar structure of states and constants and relocated them to
src/store.ts
andsrc/constant.ts
, respectively. - converted functions from expressions to declarations to ensure consistency with the existing code style.
- added detailed jsdoc comments to the
setGoogleClientId
method to improve maintainability and provide clear usage instructions.
hi @zuhno made a comment |
style: align with code style guidelines
im adding this to the v3 milestone |
I have checked this. I'll check the support for this feature in nuxt. |
@zuhno we already have a nuxt module, it needs a rewrite with newer nuxt kit once this is merged we can work on that |
i have checked the related repository and will follow up on the merge status. thanks. |
Now all looks great, i will check this out locally and then we are good to go |
Hi :)
setGoogleClientId
, which operates by changing the global ref value.GoogleSignInButton
is called.I am very happy to contribute to this project. Please let me know if there are any suggestions for improvements in the folder structure or functionality.