-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans for Dynamic clientId Updates? #60
Comments
Hi @zuhno this is a good suggestion, lets see what we can do here im initially thinking of providing a method to update the client id value in the provider as you mentioned |
@kasvith Would it be okay for me to work on it as you suggested and submit a pull request? |
sure, go ahead and do a PR, lets review it |
hi, will do. i got little busy |
Is this still in development? It would really be nice to have this feature |
hey guys sorry i was bit occupied with some work i will get back to it, seems @zuhno 's PR is fine, few final checks and its good to go im also planning on a re-write with vite 5 and upgrade support for nuxt |
hi @zuhno made few comments on PR, can you check |
hi @kasvith |
hi @zuhno replied you back yes we can support this with nuxt also, im however planning to do some migration to latest vite and nuxt with FedCM, will update the main soon |
Hello :)
Is your feature request related to a problem? Please describe.
I'm currently facing a limitation with the static assignment of the clientId value. My backend server provides redirect_uri and clientId, which I wish to dynamically utilize in my application. However, the current implementation does not allow for changing the clientId symbol value after initialization, leading to inflexibility in adapting to different server responses.
Describe the solution you'd like
I would like the ability to dynamically update the clientId value. Specifically, the solution would involve:
To implement the above, it would be necessary to optionally accept clientId during app installation.
Describe alternatives you've considered
An alternative could be a more static configuration, but this lacks the flexibility required for different backend responses. I'm open to other suggestions that could provide similar functionality.
Additional context
The inability to dynamically update the clientId hinders the adaptability of the application to different backend environments. Also, there was an issue with the package.json version not being updated, causing a failure in GitHub Action and preventing the NPM version from updating. This is an additional context that might be relevant to the overall functionality and deployment process.
The text was updated successfully, but these errors were encountered: