feat(theme): add 'inert' attribute to prevent unnecessary traversal of hidden content #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userquin
changed the title
userquin
commented
Dec 30, 2023
userquin
commented
Dec 30, 2023
src/client/theme-default/components/VPLocalNavOutlineDropdown.vue
Outdated
Show resolved
Hide resolved
|
Sidebar not woking... |
# Conflicts: # src/client/theme-default/composables/sidebar.ts # src/node/plugin.ts
brc-dd
reviewed
Jan 3, 2024
src/client/theme-default/components/VPLocalNavOutlineDropdown.vue
Outdated
Show resolved
Hide resolved
…again' into userquin/feat-add-inert-content-again
brc-dd
force-pushed
the
userquin/feat-add-inert-content-again
branch
2 times, most recently
from
5aa35f4
to
2a38b78
Compare
brc-dd
changed the title
inert to avoid traversing other menus and content when one is open
brc-dd
changed the title
inert to avoid traversing other menus and content when one is open
…gain # Conflicts: # src/client/theme-default/components/VPNavBar.vue # src/client/theme-default/composables/sidebar.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as the original #2932 but providing global inert controls and state (both exported in default theme).
Also included
focusTrapin outline (On this page) popup.