Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add print options #3124

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

userquin
Copy link
Collaborator

@userquin userquin commented Oct 22, 2023

fixes #3086
closes #2913
closes #3123

@userquin
Copy link
Collaborator Author

userquin commented Oct 22, 2023

Reviewing sizes, frontmatter aside and outline, should we export useScreenOnly composable?

@userquin
Copy link
Collaborator Author

userquin commented Oct 22, 2023

Current version printing all, maybe we can change all defaults to true changing the option to print: false | PrintOptions (we should also update the jsdocs)

@userquin
Copy link
Collaborator Author

userquin commented Oct 22, 2023

changing all defaults to true, I don't want to add a breaking change with this new feat

@userquin userquin requested a review from brc-dd October 22, 2023 18:08
@userquin
Copy link
Collaborator Author

Maybe we can add also title option to allow print icon and title, check last 2/3 commits from #2913

@brc-dd brc-dd self-assigned this Dec 30, 2023
@brc-dd brc-dd marked this pull request as draft December 30, 2023 20:36
@github-actions github-actions bot added the stale label Feb 2, 2024
@userquin userquin removed the stale label Apr 14, 2024
@userquin
Copy link
Collaborator Author

This PR will be reviewed once #3392 merged/closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar visible on print when navbar param equals false
2 participants