Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide some UI elements when printing #2913

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

Pandapip1
Copy link

@Pandapip1 Pandapip1 commented Sep 6, 2023

When I want to print an article, some UI elements still show up:
image
This PR hides them when trying to print.

@Soitora
Copy link

Soitora commented Sep 8, 2023

Should also hide "Menu" and "Search" if you don't already do that in this PR
Maybe also the "Help edit this page" and "Next/Prev" buttons

@itsWindows11
Copy link

Might even want to reduce the UI spacing/make the colors more readable but kind of outside the scope of this PR.

@Pandapip1
Copy link
Author

Should also hide "Menu" and "Search" if you don't already do that in this PR
Maybe also the "Help edit this page" and "Next/Prev" buttons

I think those are already hidden somehow. I can definitely add styling for those, though!

@Pandapip1 Pandapip1 changed the title Hide "On this page" when printing Hide some UI elements when printing Sep 8, 2023
@Pandapip1
Copy link
Author

Might even want to reduce the UI spacing/make the colors more readable but kind of outside the scope of this PR.

Agreed, but this is out of scope IMO.

@brc-dd
Copy link
Member

brc-dd commented Sep 10, 2023

I think those are already hidden somehow. I can definitely add styling for those, though!

they aren't, check on the deploy preview: https://deploy-preview-2913--vitepress-docs.netlify.app/

also why hide navbar and footer?

@Soitora
Copy link

Soitora commented Sep 10, 2023

also why hide navbar and footer?

Doesn't seem necessary for a printout, but the Site Icon+Name should be kept

@Pandapip1
Copy link
Author

Pandapip1 commented Apr 22, 2024

they aren't, check on the deploy preview: https://deploy-preview-2913--vitepress-docs.netlify.app/

Menu and search are hidden for me!

However, the website title is overlapping with the page content. Any idea how this might be fixable?

@github-actions github-actions bot removed the stale label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants