Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recursive call with cross-references #320

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: recursive call with cross-references #320

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5b2b333
fix: recursive call with cross-references
hywax Dec 28, 2023
f40d144
Merge branch 'main' into main
hywax Dec 29, 2023
a613627
fix: change order check equals object
hywax Dec 31, 2023
2502fba
Merge remote-tracking branch 'origin/main'
hywax Dec 31, 2023
23a3eb5
Merge branch 'main' into main
hywax Dec 31, 2023
d820f34
Merge branch 'main' into main
hywax Jan 5, 2024
f583948
Merge branch 'main' into main
hywax Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/plugin-vue/src/handleHotUpdate.ts
View file
Open in desktop
Expand Up @@ -212,6 +212,11 @@ function deepEqual(obj1: any, obj2: any, excludeProps: string[] = []): boolean {
return obj1 === obj2
}

// Check if both equals object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can and should be moved to the very top, no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, corrected

if (obj1 === obj2) {
return true
}

// Get the keys of the objects
const keys1 = Object.keys(obj1)
const keys2 = Object.keys(obj2)
Expand Down