fix: recursive call with cross-references #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hywax
added a commit
to hywax/mafl
that referenced
this pull request
Dec 28, 2023
yyx990803
reviewed
Dec 31, 2023
| @@ -212,6 +212,11 @@ function deepEqual(obj1: any, obj2: any, excludeProps: string[] = []): boolean { | |||
| return obj1 === obj2 | |||
| } | |||
|
|
|||
| // Check if both equals object | |||
There was a problem hiding this comment.
This can and should be moved to the very top, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an early exit from the comparison function if the objects are completely equal. If the object references are equal, you can be sure that they are equal.
Additional context
I'm running into a stack overflow problem when I use the import "ts type in defineProps" while the component is loaded via "defineAsyncComponent". Apparently cross-references are being created somewhere inside and the HMR goes into recursion. At the same time, everything else works as it should.
Error
console.log(obj1 === obj2)What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).