-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet
module makeover
#254
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ea52eab
Requalify imports in `Cooked.Wallet`
florentc 4c70840
Reduce pollution of hack to retrieve private keys
florentc db5996b
Remove legacy min ada from wallet API
florentc 367a615
Overhaul comments in Wallet
florentc 60a2aab
Remove unused functions from wallet API
florentc 81f4d79
Rename smart constructor to `initialDistribution`
florentc 4c518b2
Rename InitialDistribution field to fit convention
florentc a06129f
Apply 80 cols limit to Wallet (with reason)
florentc 3b871d3
Add heading documentation comment to Wallet module
florentc ccc037b
Apply suggestions from code review
florentc 6a3a5cc
Remove unreliable comment about a Wallet test
florentc e1babf8
Merge branch 'main' into fc/cleanup-wallet-module
florentc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this instance (and the one for
Monoid
) used anywhere execept ininitialDistribution
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not seem so. I guess it might come in handy when designing one's own distribution.