Wallet module makeover
#254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florentc
force-pushed
the
fc/cleanup-wallet-module
branch
from
2b9c503
to
dfdcc3d
Compare
florentc
force-pushed
the
fc/cleanup-wallet-module
branch
from
dfdcc3d
to
3b871d3
Compare
0xd34df00d
approved these changes
Feb 6, 2023
carlhammann
approved these changes
Feb 6, 2023
Comment on lines
110
to
111
| -- having a dedicated function makes it easy to test that this works: check | ||
| -- the @Cooked.WalletSpec@ test module. |
There was a problem hiding this comment.
There are currently no tests for this...
| ensureHasMinAda val = val <> Pl.toValue missingAda | ||
| where | ||
| missingAda = max 0 $ Pl.minAdaTxOut - Pl.fromValue val | ||
|
|
||
| instance Semigroup InitialDistribution where |
There was a problem hiding this comment.
Is this instance (and the one for Monoid) used anywhere execept in initialDistribution?
There was a problem hiding this comment.
Does not seem so. I guess it might come in handy when designing one's own distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies a cleanup pass to the
Walletmodule including the following changes (see individual commits), mostly listed here to keep track of them for V2 changelog:CardanoforCardano.***modules,Plfor everythingLedger-y, andPl1/Pl2for everything that is explicitly fromPlutus.V1orPlutus.V2(and cannot be changed to genericLedger.***).minAdasince the realminAdaamount per UTxO is not that trivial to determine. The information was therefore misleading. This also simplifiesInitialDistribution. We do not issue a dedicated custom (unreliable) error anymore. We will stumble upon validation errors if we forget to provide enough lovelace per UTxO in our initial distributions.initialDistribution'loses its prime. There was noinitialDistribution(no prime) anyway. Also the field accessor forInitialDistributionhas a more conventional (and less misleading) name.toPKHMapandvaluesForWallet.Pl.MockPrivateKeybecause no constructor or field accessor is exposed to do so. Since we have decided not to rely on explicit export lists in cooked, part of that hack has been moved away from the top-level and the weird-to-export-everywherepleasefield accessor is gone. See issue Get rid of the hack to retrieve private keys inCooked.Wallet.walletStakingSK#255: we need to make a PR to expose the info we need. We could also investigate usingSolofromData.Tupleinbaseinstead ofHACKif at some point we update our index state incabal.projectand require at leastbase 4.16