Add SmmCpuPlatformHookLib IsLmceStatusCheckNeeded interface #6557
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jiaxinwu,
jyao1,
kraxel,
LiuZhiguang001,
niruiyu,
rahul1-kumar and
td36
sweeaun
changed the title
|
please also refine the commit message according the new name: IsLmceStatusCheckNeeded |
|
use 2 commits in 1 PR for those 2 different packages changes |
jiaxinwu
reviewed
Dec 19, 2024
sweeaun
changed the title
This patch is to add IsLmceStatusCheckNeeded interface in SmmCpuPlatformHookLib. This new interface can used to check whether the LMCE status check is required. By default, it returns TRUE, indicating that the LMCE status check should be performed. However, if the check should be skipped for any reason, it can return FALSE. Signed-off-by: Khor Swee Aun <[email protected]>
This patch is to implement IsLmceStatusCheckNeeded definition for SmmCpuPlatformHookLibQemu. By default, it returns TRUE, indicating that the LMCE status check should be performed. Signed-off-by: Khor Swee Aun <[email protected]>
jiaxinwu
approved these changes
Dec 20, 2024
|
LMCE expands to "Local Machine Check Exception" I assume? The commit messages describes what is changed, but not why this change is needed. Can you please add that information? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Determines if the LMCE status check is needed.
This patch is to add IsLmceStatusCheckNeeded interface in SmmCpuPlatformHookLib. This function checks whether the LMCE status check is required.
By default, it returns TRUE, indicating that the LMCE status check should be performed. However, if the check should be skipped for any reason, it can return FALSE.
How This Was Tested
No test except compile the code successfully as new interface not being used by other code now. Test can be done once it called by other code later.