Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: allow publications to be rendered as conference talks #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Proposal: allow publications to be rendered as conference talks #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions assets/style.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,12 @@ section
color: inherit
font-style: italic
font-weight: $regular-weight

.talk
margin-bottom: $grid-height
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern of having only a bottom border hasn't been used elsewhere in the resume, but I think it has a good effect here. An alternative would be to set the top and bottom margins to half $grid-height. Using the full $grid-height felt a little too much to me 😅


.talk-name
font-weight: $semibold-weight

.presentations
margin: 0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange to remove a style explicitly set on ul by line 32, but I feel it creates a good design by making all the presentations of a talk be closely associated with the talk title

25 changes: 25 additions & 0 deletions assets/template.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,28 @@ body
span.school #{level.institution}
|  
span.time #{level.startDate.split('-')[0]} – #{level.endDate.split('-')[0]}

if publications && publications.length
section.category
- var talksObj = publications.reduce((obj, publication) => {
- obj[publication.name] = (obj[publication.name] || []).concat(publication)
- return obj
- }, {})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied the logic above on L107-L110 as an example to avoid setting any new patterns.

I think a good improvement would be to extract the transformation logic. That is, have one file where we take the data from CSON and transform it to the format expected by the template


h2 Conference talks

ul.talks
each presentations, talk in talksObj
li.talk
.talk-name #{talk}
ul.presentations
each presentation in presentations
li.presentation
span.presentation-name
| #{presentation.publisher}, 
span.presentation-date
| #{presentation.releaseDate}
if presentation.website
span.presentation-video
|  
+link(presentation.website)