Proposal: allow publications to be rendered as conference talks #8
Conversation
| @@ -117,3 +117,12 @@ section | |||
| color: inherit | |||
| font-style: italic | |||
| font-weight: $regular-weight | |||
|
|
|||
| .talk | |||
| margin-bottom: $grid-height | |||
There was a problem hiding this comment.
This pattern of having only a bottom border hasn't been used elsewhere in the resume, but I think it has a good effect here. An alternative would be to set the top and bottom margins to half $grid-height. Using the full $grid-height felt a little too much to me 😅
| font-weight: $semibold-weight | ||
|
|
||
| .presentations | ||
| margin: 0 |
There was a problem hiding this comment.
It's strange to remove a style explicitly set on ul by line 32, but I feel it creates a good design by making all the presentations of a talk be closely associated with the talk title
| - var talksObj = publications.reduce((obj, publication) => { | ||
| - obj[publication.name] = (obj[publication.name] || []).concat(publication) | ||
| - return obj | ||
| - }, {}) |
There was a problem hiding this comment.
I copied the logic above on L107-L110 as an example to avoid setting any new patterns.
I think a good improvement would be to extract the transformation logic. That is, have one file where we take the data from CSON and transform it to the format expected by the template
|
If anyone would like to leave some comments, without going through the full process of generating a resume, here is a screenshot: |
|
@JuanCaicedo Publications seems like the right place to put talks, and I like visually what's happening with the list of talks. However, I wonder if this setup closes off the possibility of using publications for publications (e.g., books, blog posts). Maybe I'm just imagining a problem that doesn't exist (given that no one yet uses publications in our résumés), but it seems like something we might want in the future? Feel free to ignore me if I'm just pre-factoring though. 😁 |
|
@rosston That's a valid concern. Perhaps someone with a more academic background would want to showcase some things that they've published (in like real publications 😄) Maybe we can cross that bridge when we get to it, by adding something in the talk name that distinguishes if it's a conference/publication and doesn't get rendered. Also maybe jsonresume will come up with a way of handling this by that point |
|
That's fair. I'm good with punting on the issue until it becomes a problem. |
|
I like this change, but I'll +1 that it would be nice to distinguish between talks and publications, considering I would like to add my book the next time I update my resume 😄 But, maybe we can cross that bridge when we get to it like you mention. |
Why
It would be nice to be able to share the talks we've given on our resumes, to showcase our expertise and experience.
How to test
npm linknpm link cobblercurl https://juan-caicedo-resume-cson.now.sh > test-resume.csoncobbler -i test-resume.cson -o test-output.pdf && open test-output.pdfI'll comment in the code areas where I would like specific feedback, though any is appreciated 😄