Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Take 2) Fix oob index in sparse example #2290

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

ericcanton
Copy link
Contributor

Re-making this PR commit after updating my Google CLA and GitHub email settings to make this commit using the email address I signed with.

From my other PR:

A sparse matrix with shape [4, 10] is being assigned an element at location [7, 0]. This changes that to the valid [3, 0].

Thanks for your time.

Re-making this commit after updating my Google CLA and GitHub email settings.
@ericcanton ericcanton requested a review from a team as a code owner December 7, 2023 17:31
Copy link

github-actions bot commented Dec 7, 2023

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-3

@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Dec 20, 2023
Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't that an error?

@8bitmp3 8bitmp3 added ready to pull Start merge process and removed review in progress Someone is actively reviewing this PR labels Dec 21, 2023
@8bitmp3 8bitmp3 added ready to pull Start merge process and removed ready to pull Start merge process labels Apr 11, 2024
@8bitmp3 8bitmp3 removed the ready to pull Start merge process label Sep 4, 2024
@8bitmp3 8bitmp3 self-assigned this Sep 4, 2024
@8bitmp3 8bitmp3 added the ready to pull Start merge process label Sep 4, 2024
@ericcanton ericcanton closed this Sep 4, 2024
@copybara-service copybara-service bot merged commit 69a53ae into tensorflow:master Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants