Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oob index in sparse example #2288

Closed
wants to merge 1 commit into from

Conversation

ericcanton
Copy link
Contributor

A sparse matrix with shape [4, 10] is being assigned an element at location [7, 0]. This changes that to the valid [3, 0].

Thanks for your time.

A sparse matrix with shape [4, 10] is being assigned an element at location [7, 0]. This changes that to the valid [3, 0].
@ericcanton ericcanton requested a review from a team as a code owner November 27, 2023 03:32
Copy link

google-cla bot commented Nov 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin patch-2

@8bitmp3 8bitmp3 added the review in progress Someone is actively reviewing this PR label Dec 5, 2023
@8bitmp3
Copy link
Contributor

8bitmp3 commented Dec 5, 2023

thanks @ericcanton, can you also check the CLA - see the message from google-cla above for details 👍

@ericcanton
Copy link
Contributor Author

Thanks for your comment @8bitmp3 . I had to re-make the commit, to use the email address that's on file with my CLA. Find that updated PR here. I'll close this one!

@ericcanton ericcanton closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review in progress Someone is actively reviewing this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants