Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error of provided change ID is too old #240

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Return error of provided change ID is too old #240

merged 2 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. corro-client: fail if change is too new after subscribe 

    If the client subscribes with known change ID fail the request in
case Corrosion returns a change with a gap, meaning the original change
has already been recycled. Instead of silently ignoring the error
force the client to subscribe from scratch.
    @pborzenkov
    pborzenkov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    87f6fc6 View commit details
    Browse the repository at this point in the history

  2. corro-client: add 3 seconds timeout to DNS resolves 

    Otherwise they may take a while without printing anything to the logs,
which makes it really hard to debug problems.
    @pborzenkov
    pborzenkov committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    927163e View commit details
    Browse the repository at this point in the history