Return error of provided change ID is too old #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client subscribes with known change ID fail the request in case Corrosion returns a change with a gap, meaning the original change has already been recycled. Instead of silently ignoring the error force the client to subscribe from scratch.
Otherwise they may take a while without printing anything to the logs, which makes it really hard to debug problems.
jeromegn
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes client's behavior to return an error if the change ID provided to subscription handler
is too old and already recycled on the server side.
The PR also introduces DNS resolve timeout to make sure something is printed to the logs if DNS resolve
takes too much time.