Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Composer): update to latest wpcs release #38

Closed
wants to merge 2 commits into from
Closed

chore(Composer): update to latest wpcs release #38

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2017

closes #37

For those who want this now:

{
  "repositories": [{
    "url": "https://github.com/jhabdas/wp-enforcer.git",
    "type": "git"
  }],
  "require-dev": {
    "stevegrunwell/wp-enforcer": "dev-master"
  }
}

EDIT: Probably don't use this until #38 (comment) is addressed.

@ghost
Copy link
Author

ghost commented May 20, 2017

@stevegrunwell could you please switch the default branch back to master and update there. this current rig feels sdrawkcab?

@ghost
Copy link
Author

ghost commented May 20, 2017

Yep. I'm totally backed against the wrong branch in my fork due to the branch polarity reversal here. I'm going to push a hack up for now until I hear back before I rebase and update this pull to fix #39

git diff --name-only --cached --diff-filter=ACMRTUXB | xargs vendor/bin/phpcs $standard
if [ $? != 0 ]
then
composer run lint:plugin
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this command coming from? While it's handy to have a Composer script to run, I don't see a definition for this anywhere (nor is WP Enforcer only used for plugins, as this command seems to indicate).

@stevegrunwell
Copy link
Owner

@stevegrunwell could you please switch the default branch back to master and update there. this current rig feels sdrawkcab?

The branching strategy isn't backwards, it may be just be a bit different than what you're used to (especially if you're typically using a "branch off of master, then merge into staging and/or master to deploy to staging or production, respectively" workflow).

As outlined in the contributing doc, new feature branches should come off of develop (which is the primary branch); the only time things are merged to master is when a new release is tagged, and that's by way of a release/x.x.x branch.

If you're not familiar with this pattern (commonly referred to as "Gitflow"), I'd recommend checking out this documentation from Atlassian.

@ghost
Copy link
Author

ghost commented May 28, 2017

Closing this as the WP-CLI generates sample-plugin containing a travis config which, for better or worse, does a global install of wpcs during CI, meaning it'll always get the latest build. As a result, it's probably better to set the version of wpcs to * to take upgrades as coding standards roll forward as opposed to seeing pulls like this which would simply cause noise in an already noisy world.

I'll open a bug for the related change, but I'm pulling back from using wp-enforcer myself as I find it confusing to directly depend on wpcs when it should really be a peer dependency.

@ghost ghost closed this May 28, 2017
@ghost ghost mentioned this pull request May 28, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require latest version of WPCS always
1 participant