Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require latest version of WPCS always #37

Closed
ghost opened this issue May 20, 2017 · 7 comments
Closed

Require latest version of WPCS always #37

ghost opened this issue May 20, 2017 · 7 comments
Milestone

Comments

@ghost
Copy link

ghost commented May 20, 2017

Currently composer.json has a hard dependency on WPCS, and is using 0.10.0. Because they're not at a 1.0 and the current rule is ^ this change will not be automatic for minor updates (only one a major lands will that be true). As a result, we need to update to the new standard manually.

@ghost
Copy link
Author

ghost commented May 20, 2017

https://github.com/jhabdas/wp-enforcer/blob/develop/CHANGELOG.md#042---2017-01-04

Don't lock wp-coding-standards/wpcs to a single version.
Remove the explicit package version in composer.json, add GitHub URLs.

Where are those changes?

@ghost
Copy link
Author

ghost commented May 20, 2017

@stevegrunwell could you let me know what versioning tool and changelog generator you are using to manage this project since they're not installed as a dev dependency? I may need to fork and want to be able to merge back together.

@stevegrunwell stevegrunwell added this to the 0.5.0 milestone May 27, 2017
@stevegrunwell
Copy link
Owner

Where are those changes?

That particular change was in a521897, where the version number was bumped but, as you pointed out, the version number is still getting locked-in.

@stevegrunwell could you let me know what versioning tool and changelog generator you are using to manage this project since they're not installed as a dev dependency? I may need to fork and want to be able to merge back together.

The versioning of the plugin is manual: each feature branch includes a relevant change to the CHANGELOG.md file (under the "[Unreleased]" header). When a new release is being prepared, I branch release/x.x.x off of develop, bump version numbers + update documentation accordingly, then merge release/x.x.x via a non-fast-forward merge into master, tag the release, then merge master into develop.

This approach ensures people can easily see features/fixes in develop that haven't yet hit a stable release, should they choose to use the more "bleeding-edge" version.

@ghost
Copy link
Author

ghost commented May 28, 2017

Please see #38 (comment) for my suggestion on how to enable future upgrades. Note that before dependencies go to 1.0.0 the ^ works differently and will not take a minor, assuming it works like NPM. That's why #35 is important.

@ghost ghost changed the title Bump to WPCS 0.11.0 Require latest version of WPCS always May 28, 2017
@davegreenwp
Copy link

hi @stevegrunwell @JHabdas I'm literally in the process of introducing this into our workflow, and I need to be able use some of the custom sniff rules that were introduced in WPCS 0.11.0 and 0.12.0.

How can I go about this independently, before the version bump is made in this repo? Is it just a case of specifying a more recent version in composer.json?

Any guidance appreciated. Fantastic tool!

@stevegrunwell
Copy link
Owner

Hey @davetgreen, I just tagged version 0.5.0, which follows @JHabdas' recommendation to use * for the WPCS version, ensuring you should get the latest :)

@davegreenwp
Copy link

@stevegrunwell you sir are an absolute legend

Much obliged /tiphat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants