Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed popup overflow by suggestions #35

Merged
merged 12 commits into from
May 29, 2023
Merged

Fixed popup overflow by suggestions #35

merged 12 commits into from
May 29, 2023

Commits on May 25, 2023

  1. Fixed popup overflow by suggestions 

    Wrapped the popup content in a SingleChildScrollView;
Constrained the height of the popup;

Changed the `MistakeBuilderCallback` typedef to match the signature of the `LanguageToolMistakePopup` unnamed constructor for simpler interoperability.
    @mitryp
    mitryp committed May 25, 2023
    Configuration menu
    Copy the full SHA
    53d1df3 View commit details
    Browse the repository at this point in the history

  2. Improved performance with many suggestions 

    Changed `Wrap` to `SliverList.builder` with a `CustomScrollView`
    @mitryp
    mitryp committed May 25, 2023
    Configuration menu
    Copy the full SHA
    47056f9 View commit details
    Browse the repository at this point in the history

  3. Undid SliverList builder method extraction

    @mitryp
    mitryp committed May 25, 2023
    Configuration menu
    Copy the full SHA
    d6c2903 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Moved LanguageToolMistakePopup fields up 

    for them to be before the constructor.
    @mitryp
    mitryp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    6c590b5 View commit details
    Browse the repository at this point in the history

  2. Fixed SliverList taking all the vertical space

    @mitryp
    mitryp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    05f37a0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/popup-suggestions-overflow

    @mitryp
    mitryp authored May 26, 2023
    Configuration menu
    Copy the full SHA
    f8cf10b View commit details
    Browse the repository at this point in the history

  4. Fixed paddings

    @mitryp
    mitryp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    d873e26 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix/popup-suggestions-overflow' of https://github.com/s… 

    …olid-software/languagetool_textfield into fix/popup-suggestions-overflow
    @mitryp
    mitryp committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f8910f2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Moved popup constraints and margins into the popup

    @mitryp
    mitryp committed May 29, 2023
    Configuration menu
    Copy the full SHA
    ebb3b36 View commit details
    Browse the repository at this point in the history

  2. Fixed incorrect placement of the popup 

    In cases when its size was calculated to fill the available space pixel-perfect.
    @mitryp
    mitryp committed May 29, 2023
    Configuration menu
    Copy the full SHA
    b60603a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into fix/popup-suggestions-overflow

    @mitryp
    mitryp authored May 29, 2023
    Configuration menu
    Copy the full SHA
    65d1944 View commit details
    Browse the repository at this point in the history

  4. Removed the commented out code

    @mitryp
    mitryp committed May 29, 2023
    Configuration menu
    Copy the full SHA
    35138c8 View commit details
    Browse the repository at this point in the history