Fixed popup overflow by suggestions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped the popup content in a SingleChildScrollView; Constrained the height of the popup; Changed the `MistakeBuilderCallback` typedef to match the signature of the `LanguageToolMistakePopup` unnamed constructor for simpler interoperability.
Changed `Wrap` to `SliverList.builder` with a `CustomScrollView`
solid-vovabeloded
requested changes
May 25, 2023
There was a problem hiding this comment.
Well done, @mitryp. I've added a couple of suggestions here - please, take a look.
for them to be before the constructor.
|
If there is only one suggestion it is displayed like this: |
|
I must have missed something. Will fix |
solid-vovabeloded
requested changes
May 29, 2023
There was a problem hiding this comment.
Well done investigating the problem, @mitryp. I've added one more suggestion here - please, take a look.
In cases when its size was calculated to fill the available space pixel-perfect.
solid-vovabeloded
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32
Fixes #36
Wrapped the popup content in a SingleChildScrollView;
Constrained the height of the popup;
Added the
maxHeightoptional parameter to the LanguageToolMistakePopup;Changed the
MistakeBuilderCallbacktypedef to match the signature of theLanguageToolMistakePopupunnamed constructor for simpler interoperability.