Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions popup #28

Closed
wants to merge 16 commits into from
Closed

Suggestions popup #28

wants to merge 16 commits into from

Commits on May 10, 2023

  1. Basic widget to display replacements for a mistake.

    @Sammy275
    Sammy275 committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4b8241a View commit details
    Browse the repository at this point in the history

  2. Updated the feature now it has an overlay instead of a dialog

    @Sammy275
    Sammy275 committed May 10, 2023
    Configuration menu
    Copy the full SHA
    f6f8ebd View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Visual fixes,only 4 or less suggestions will appear, added documentation

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f260d84 View commit details
    Browse the repository at this point in the history

  2. Restructuringof the pop up widget

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    bf6d6be View commit details
    Browse the repository at this point in the history

  3. Removed magic value and added static default suggestions limit

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c94d145 View commit details
    Browse the repository at this point in the history

  4. Added the functionality of closing the suggestions pop up

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    47c6790 View commit details
    Browse the repository at this point in the history

  5. Updated the formating and documentation

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0e28900 View commit details
    Browse the repository at this point in the history

  6. Added logic to calculate the x axis of the popup so it does not excee… 

    …d the screen
    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    462cc11 View commit details
    Browse the repository at this point in the history

  7. Updated documentation

    @SaimIrfan
    SaimIrfan committed May 11, 2023
    Configuration menu
    Copy the full SHA
    4185617 View commit details
    Browse the repository at this point in the history

  8. Removed magic values

    @Sammy275
    Sammy275 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    2103afb View commit details
    Browse the repository at this point in the history

  9. Removed non null assertion

    @Sammy275
    Sammy275 committed May 11, 2023
    Configuration menu
    Copy the full SHA
    df7afca View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Added a getter in Mistake class to get the name. Resolved the non nul… 

    …l assertion issue as suggested by Yuri
    @Sammy275
    Sammy275 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    6a6c12d View commit details
    Browse the repository at this point in the history

  2. The suggestion popup's design can now be added from outside.

    @Sammy275
    Sammy275 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    bf6999d View commit details
    Browse the repository at this point in the history

  3. Fixed formatiing of the code

    @Sammy275
    Sammy275 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    b03ba4b View commit details
    Browse the repository at this point in the history

  4. The text box will now appear right beneath the mistake instead being … 

    …displayed where the user tapped.
    @Sammy275
    Sammy275 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fd7b2d3 View commit details
    Browse the repository at this point in the history

  5. Removing the overlay when the controller gets disposed

    @Sammy275
    Sammy275 committed May 12, 2023
    Configuration menu
    Copy the full SHA
    7501bdd View commit details
    Browse the repository at this point in the history