Suggestions popup #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solid-yuriiprykhodko
requested changes
May 11, 2023
Comment on lines
128
to
129
| /// it will be slightly below the tapped area. | ||
| final newDy = position.dy + 10; |
There was a problem hiding this comment.
Is it possible to position the popup relative to the text, and not tap area?
Hardcoded offset from tap location won't look well if the font size is larger.
…l assertion issue as suggested by Yuri
…displayed where the user tapped.
solid-yuriiprykhodko
requested changes
May 12, 2023
Comment on lines
+34
to
+41
| final Widget Function( | ||
| String name, | ||
| String message, | ||
| Color color, | ||
| List<String> replacements, | ||
| Function(String) onSuggestionTap, | ||
| Function() onClose, | ||
| )? mistakeBuilder; |
There was a problem hiding this comment.
- No need to provide the colour ourselves. Let it be resolved dynamically from MistakeType.
- Use typedef for better readability.
Suggested change
| final Widget Function( | |
| String name, | |
| String message, | |
| Color color, | |
| List<String> replacements, | |
| Function(String) onSuggestionTap, | |
| Function() onClose, | |
| )? mistakeBuilder; | |
| typedef ReplacementSuggestionsBuilder = Widget Function( | |
| Mistake mistake, | |
| List<String> replacements, | |
| Function(String) onSuggestionTap, | |
| Function() onClose, | |
| ); | |
| final ReplacementSuggestionsBuilder? mistakeBuilder; |
| } | ||
|
|
||
| @override | ||
| void dispose() { |
There was a problem hiding this comment.
Move this to the bottom of the class.
That's company convention -- all cleanup/disposal should be placed at the very bottom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the work related to the suggestions popup that appears on a mistake.