refs #3 CircleCIの導入 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[エビデンス] rspecが実行できる：https://circleci.com/gh/sitateru/exam/13 ただ普通にテストに落ちてるので修正しないといけなさそう |
|
API叩くときにリビジョン指定できた |
|
出題当 041070de3b913e293e3c2e24cf39ddf985d148d5 私のPRが入ったところd87f10a @tibaraki |
This reverts commit dbe41fc.
|
課題趣旨に応じた実装はしていただいていると思いますが、revert後にコケちゃってますのでmergeはしないでおきます |
|
ありがとうございます。お言葉に甘えて というわけではありませんが 本日（10/2）が期日の認識なので、いったんできるだけ先のissueに取り掛かることにします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3へのPRです