[mod_spandsp] Fix compilation against >=2023/06/02 spandsp #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywolk
force-pushed
the
fix_spandsp_v18_breaking_changes
branch
from
54c664a to
7d06105
Compare
spandsp, beginning with commit d9681c37 and coinciding with the SPANDSP_RELEASE_DATE of 20230620, introduced the following changes to its V.18 protocol API, which FreeSWITCH is not able to compile against: - Certain V.18 constants were renamed. - The v18_init function now requires passing a third function, handling the V.18 modem's status changes. This patch allows FreeSWITCH to build against current versions of spandsp by: - Using the new V.18 constant names. - Implementing a simple status reporter callback function and passing it as the third function to v18_init. Additionally, it retains backward compatibility with prior versions of spandp through #if conditions checking the value of SPANDSP_RELEASE_DATE. Signed-off-by: Patrice Fournier <[email protected]>
andywolk
force-pushed
the
fix_spandsp_v18_breaking_changes
branch
from
7d06105 to
65093fe
Compare
andywolk
requested changes
Dec 19, 2024
| @@ -213,8 +224,11 @@ switch_status_t spandsp_tdd_send_session(switch_core_session_t *session, const c | |||
| return SWITCH_STATUS_FALSE; | |||
| } | |||
|
|
|||
| #if SPANDSP_RELEASE_DATE >= 20230620 | |||
| tdd_state = v18_init(NULL, TRUE, get_v18_mode(session), V18_AUTOMODING_GLOBAL, put_text_msg, NULL, handle_v18_status, NULL); | |||
There was a problem hiding this comment.
user data is null and will crash in handle_v18_status due to a null pointer dereference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch from my colleague allows FreeSWITCH to compile with latest or earlier spandsp code base:
spandsp, beginning with commit d9681c37 and coinciding with the SPANDSP_RELEASE_DATE of 20230620, introduced the following changes to its V.18 protocol API, which FreeSWITCH is not able to compile against:
This patch allows FreeSWITCH to build against current versions of spandsp by:
Additionally, it retains backward compatibility with prior versions of spandp through #if conditions checking the value of SPANDSP_RELEASE_DATE.