Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod_spandsp] Compatible with the new version of spandsp. #2541

Closed
wants to merge 1 commit into from

Conversation

azzbcc
Copy link
Contributor

@azzbcc azzbcc commented Jul 28, 2024

No description provided.

@andywolk
Copy link
Contributor

Thank you. Will this work on Windows?

@azzbcc
Copy link
Contributor Author

azzbcc commented Aug 5, 2024

I don't have windows environment.

@ThomasLobker
Copy link

Thanks so much for sharing @azzbcc

This works for me when building on Ubuntu 24.04 with the latest version of spandsp.

@pfournier
Copy link
Contributor

While this patch allows FreeSWITCH to compile with the newest spandsp code base, it won't be compatible with older spandsp anymore. But furthermore, it passes a null pointer as the handler to use by spandsp which doesn't check if the handler is set before calling it, so in case of V.18 mode change, FreeSWITCH would crash with a call to null-pointer.

A more complete pull request is available at #2668.

@azzbcc azzbcc closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants