Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iterable Lists] - STRATCONN-4357 - Fixing "Additional traits or identifiers must be a string but it was an object." error in Iterable Lists. #2541

Merged
merged 4 commits into from
Nov 12, 2024
Merged

[Iterable Lists] - STRATCONN-4357 - Fixing "Additional traits or identifiers must be a string but it was an object." error in Iterable Lists. #2541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
489a4c8
Fixing "Additional traits or identifiers must be a string but it was …
seg-leonelsanches Oct 29, 2024
1b014f8
Updating generated types.
seg-leonelsanches Oct 29, 2024
fc02e21
Updating data fields description.
seg-leonelsanches Oct 31, 2024
11e31ed
updating generated types
joe-ayoub-segment Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/destination-actions/src/destinations/iterable-lists/syncAudience/generated-types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/destination-actions/src/destinations/iterable-lists/syncAudience/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ const action: ActionDefinition<Settings, Payload, AudienceSettings> = {
dataFields: {
label: 'Additional traits or identifiers',
description:
'Comma delimited list containing names of additional traits or identifiers to sync to Iterable. You will need to ensure these traits or obects are included via Event Settings >> Customized Setup.',
'Additional traits or identifiers to sync to Iterable. You will need to ensure these traits or objects are included via Event Settings > Customized Setup.',
required: false,
type: 'string'
type: 'object'
},
traitsOrProperties: {
label: 'Traits or Properties',
Expand All @@ -55,7 +55,7 @@ const action: ActionDefinition<Settings, Payload, AudienceSettings> = {
},
segmentAudienceKey: {
label: 'Segment Audience Key',
description: 'Segment Audience Key. Maps to the "Name" of the Segment node in Yahoo taxonomy',
description: 'Segment Audience Key. Maps to the Iterable List "Name" when the list is created in Iterable.',
type: 'string',
unsafe_hidden: true,
required: true,
Expand Down
8 changes: 4 additions & 4 deletions packages/destination-actions/src/destinations/iterable-lists/syncAudience/iterable-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ export class IterableListsClient {
if (payload.traitsOrProperties[payload.segmentAudienceKey] === true) {
const subscriber = {
email: payload?.email ?? undefined,
dataFields: payload?.dataFields?.split(',').reduce((acc: { [key: string]: unknown }, item: string) => {
acc[item.trim()] = payload.traitsOrProperties[item.trim()]
return acc
}, {}),
userId: payload?.userId ?? undefined,
preferUserId: true
} as Subscriber

if (payload?.dataFields) {
subscriber.dataFields = payload.dataFields as Record<string, null | boolean | string | number | object>
}

if (subscribersGroup.has(listId)) {
subscribersGroup.get(listId)?.push(subscriber)
} else {
Expand Down
Loading