-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Iterable Lists] - STRATCONN-4357 - Fixing "Additional traits or identifiers must be a string but it was an object." error in Iterable Lists. #2541
Conversation
…an object." error in Iterable Lists.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
==========================================
+ Coverage 78.39% 78.40% +0.01%
==========================================
Files 1012 1012
Lines 17794 17795 +1
Branches 3349 3355 +6
==========================================
+ Hits 13950 13953 +3
+ Misses 2720 2719 -1
+ Partials 1124 1123 -1 ☔ View full report in Codecov by Sentry. |
packages/destination-actions/src/destinations/iterable-lists/syncAudience/index.ts
Outdated
Show resolved
Hide resolved
LGTM @seg-leonelsanches - just that single comment to take care of. |
Thank you, @joe-ayoub-segment. This is done. |
Pushed an updated - generated-types.ts needed updating. |
hi @seg-leonelsanches - qq is this PR for this JIRA ticket? |
Hi @joe-ayoub-segment. No, this is for https://segment.atlassian.net/browse/STRATCONN-4357. The following ticket, https://segment.atlassian.net/browse/STRATCONN-4358, is another problem, also with this destination. |
hi @seg-leonelsanches PR deployed. |
Changing
dataFields
to be an object, not a string. Fixes this problem:Testing
Payload for Postman (local):