stall-analyser: gracefully handle empty input #2305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jun 27, 2024
scripts/stall-analyser.py
Outdated
| if t >= tmin: | ||
| graph.process_trace(trace, t) | ||
|
|
||
| try: | ||
| if not graph: | ||
| print("No input data found. Please run `stall-analyser.py --help` for usage instruction") | ||
| exit(0) |
There was a problem hiding this comment.
i'd suggest use sys.exit() instead. see https://docs.python.org/3/library/constants.html#constants-added-by-the-site-module . i am quoting the remarks in the document.
They are useful for the interactive interpreter shell and should not be used in programs.
Currently, the tools prints an obscure error
if the input is empty:
```
Traceback (most recent call last):
File "/home/bhalevy/dev/scylla_s3_reloc_server/./seastar//scripts/stall-analyser.py", line 363, in <module>
print_stats(tally, tmin)
^^^^
NameError: name 'tmin' is not defined. Did you mean: 'min'?
```
Instead, print a meaningful error and direct the user
to run stall-analyser.py --help for usage instructions.
Ref scylladb/scylla_s3_reloc_server#103
Signed-off-by: Benny Halevy <[email protected]>
bhalevy
force-pushed
the
stall-annalyser-handle-empty-input-gracefully
branch
from
12480e9
to
f0b62cb
Compare
|
@scylladb/seastar-maint please merge |
ptrsmrn
pushed a commit
to ptrsmrn/seastar
that referenced
this pull request
Jul 17, 2024
Currently, the tools prints an obscure error
if the input is empty:
```
Traceback (most recent call last):
File "/home/bhalevy/dev/scylla_s3_reloc_server/./seastar//scripts/stall-analyser.py", line 363, in <module>
print_stats(tally, tmin)
^^^^
NameError: name 'tmin' is not defined. Did you mean: 'min'?
```
Instead, print a meaningful error and direct the user
to run stall-analyser.py --help for usage instructions.
Ref scylladb/scylla_s3_reloc_server#103
Signed-off-by: Benny Halevy <[email protected]>
Closes scylladb#2305
lovio
pushed a commit
to lovio/seastar
that referenced
this pull request
Aug 30, 2024
Currently, the tools prints an obscure error
if the input is empty:
```
Traceback (most recent call last):
File "/home/bhalevy/dev/scylla_s3_reloc_server/./seastar//scripts/stall-analyser.py", line 363, in <module>
print_stats(tally, tmin)
^^^^
NameError: name 'tmin' is not defined. Did you mean: 'min'?
```
Instead, print a meaningful error and direct the user
to run stall-analyser.py --help for usage instructions.
Ref https://github.com/scylladb/scylla_s3_reloc_server/pull/103
Signed-off-by: Benny Halevy <[email protected]>
Closes scylladb#2305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tools prints an obscure error
if the input is empty:
Instead, print a meaningful error and direct the user to run stall-analyser.py --help for usage instructions.
Ref https://github.com/scylladb/scylla_s3_reloc_server/pull/103