stall-analyser: use 0 for default value of --minimum #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Presumably obsoleted by #2305 ? |
this change is a cleanup. it: - use a better name for the `--minimum` option, `args.minimum` is way too general. - use the default value of 0 instead of `None`, simpler this way - just reference `arg.tmin`, simpler this way Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
stall-analyser-handle-empty-file
branch
from
f8f5875
to
5fa4c9c
Compare
tchaikov
changed the title
i degraded it from a fix to a cleanup . |
|
@scylladb/seastar-maint please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change is a cleanup. it:
--minimumoption,args.minimumis way too general.
None, simpler this wayarg.tmin, simpler this way