Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update currency main symbol and currency native symbol for AZN. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update currency main symbol and currency native symbol for AZN. #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions price_parser/_currencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@
"np": "Aruban Florins"
},
"AZN": {
"s": "man.",
"s": "₼",
Copy link
Member

@kmike kmike Oct 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @dashgin! Is it the case that the older symbols are wrong, and not used in practice (e.g. on websites)? If man. / ман. are still used, I think we need to ensure that both of them are handled by price-parser. Probably, it makes sense to use sn2 key for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also please add a test for the change? Based on

price-parser/tests/test_price_parsing.py

Line 10 in 82c27a8

PRICE_PARSING_EXAMPLES_BUGS_CAUGHT are manually added examples for the bugs
, it probably should be a new example in PRICE_PARSING_EXAMPLES_NEW.

"n": "Azerbaijani Manat",
"sn": "ман.",
"sn": "₼",
"d": 2,
"r": 0,
"np": "Azerbaijani manats"
Expand Down