Update currency main symbol and currency native symbol for AZN. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
approved these changes
Sep 14, 2022
kmike
reviewed
Oct 11, 2022
| @@ -109,9 +109,9 @@ | |||
| "np": "Aruban Florins" | |||
| }, | |||
| "AZN": { | |||
| "s": "man.", | |||
| "s": "₼", | |||
There was a problem hiding this comment.
hey @dashgin! Is it the case that the older symbols are wrong, and not used in practice (e.g. on websites)? If man. / ман. are still used, I think we need to ensure that both of them are handled by price-parser. Probably, it makes sense to use sn2 key for this.
There was a problem hiding this comment.
Could you also please add a test for the change? Based on
price-parser/tests/test_price_parsing.py
Line 10 in 82c27a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update currency main symbol and currency native symbol for AZN(Azerbaijani Manat).