Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SASS deprecation warning #1672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

palicko
Copy link

@palicko palicko commented Nov 15, 2024

Hey, these small changes fix SASS deprecated warnings as mentioned in #1657 and #1647

Deprecation Warning on line 36, column 8 of
│ │ node_modules/lightgallery/scss/lg-autoplay.scss:36:8:
│ │ Sass's behavior for declarations that appear after nested
│ │ rules will be changing to match the behavior specified by CSS in an
│ │ upcoming
│ │ version. To keep the existing behavior, move the declaration above the
│ │ nested
│ │ rule. To opt into the new behavior, wrap the declaration in `& {}`.
│ │ More info: https://sass-lang.com/d/mixed-decls
│ │ 36 |         content: '/e01d';
│ │ node_modules/lightgallery/scss/lg-autoplay.scss 37:9          @import
│ │ node_modules/lightgallery/scss/lightgallery-bundle.scss 23:9  @import
│ │ resources/styles/lightgallery.scss 16:9                       root
│ │ stylesheet

and

│ │ Deprecation Warning on line 163, column 8 of
│ │ node_modules/lightgallery/scss/lightgallery-core.scss:163:8:
│ │ Sass's behavior for declarations that appear after nested
│ │ rules will be changing to match the behavior specified by CSS in an
│ │ upcoming
│ │ version. To keep the existing behavior, move the declaration above the
│ │ nested
│ │ rule. To opt into the new behavior, wrap the declaration in `& {}`.
│ │ More info: https://sass-lang.com/d/mixed-decls
│ │ 163 |         display: none !important;
│ │ node_modules/lightgallery/scss/lightgallery-core.scss 164:9   @import
│ │ node_modules/lightgallery/scss/lightgallery-bundle.scss 34:9  @import
│ │ resources/styles/lightgallery.scss 16:9                       root
│ │ stylesheet

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants