Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Warning About Future Changes #1647

Open
jledgett opened this issue Jul 11, 2024 · 4 comments
Open

SASS Warning About Future Changes #1647

jledgett opened this issue Jul 11, 2024 · 4 comments

Comments

@jledgett
Copy link

When using the packing lightgallery's SCSS files into a project I now receive the following warning:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ╷
160 │ ┌         &:not(.lg-start-end-progress) {
161 │ │             background: url('#{$lg-path-images}/loading.gif') no-repeat scroll
162 │ │                 center center transparent;
163 │ │         }
    │ └─── nested rule
164 │           display: none !important;
    │           ^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    node_modules/lightgallery/scss/lightgallery-core.scss 164:9  @import
    node_modules/lightgallery/scss/lightgallery.scss 7:9         @import
    wwwroot/scss/site.scss 13:9                                  root stylesheet

Can you please resolve before deprecation occurs?

@jledgett jledgett changed the title SaaS Warning About Future Changes SaSS Warning About Future Changes Jul 11, 2024
@jledgett jledgett changed the title SaSS Warning About Future Changes SASS Warning About Future Changes Jul 11, 2024
Copy link

stale bot commented Sep 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the v1 label Sep 10, 2024
@johanwilfer
Copy link

This is also the case in v2, so the v1 tag here is incorrect? Can this be addressed?

Copy link

stale bot commented Dec 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the v1 label Dec 12, 2024
@henriksonnergard
Copy link

Still an issue, which seems like it will be solved by #1672

@stale stale bot removed the v1 label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants