Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register fundtx change #2714

Open
wants to merge 12 commits into
base: save_fund_tx_signed_instead_of_hash
Choose a base branch
from
Open

Register fundtx change #2714

wants to merge 12 commits into from

Commits on Sep 16, 2024

  1. When signed, save the svp fund tx instead of its hash

    @julia-zack
    julia-zack committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    6a4e4f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Correct typo and comments

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    729776e View commit details
    Browse the repository at this point in the history

  2. Add method to process svp fund tx hash signed

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    081976b View commit details
    Browse the repository at this point in the history

  3. Add tests for registering the svp fund transaction through registerBt… 

    …cTransaction
    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8fcb092 View commit details
    Browse the repository at this point in the history

  4. Refactor

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    42a6d9b View commit details
    Browse the repository at this point in the history

  5. Reorder methods to improve tests readability

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    58fb0e8 View commit details
    Browse the repository at this point in the history

  6. Move btcBlockStore variables from global setup to specific setup

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    61eb833 View commit details
    Browse the repository at this point in the history

  7. Change method name to be more accurate

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    085768f View commit details
    Browse the repository at this point in the history

  8. Add log to help with debugging

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76038c9 View commit details
    Browse the repository at this point in the history

  9. Move global variables to local method to fix sonar complain

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    0a770b3 View commit details
    Browse the repository at this point in the history

  10. Add test for svp transaction without output change

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4519795 View commit details
    Browse the repository at this point in the history

  11. Adapt to have the svp fund tx signed instead of the hash

    @julia-zack
    julia-zack committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    8256285 View commit details
    Browse the repository at this point in the history