Register fundtx change #2714
Open
Register fundtx change #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julia-zack
force-pushed
the
add_method_to_check_svp_period
branch
from
73703d4
to
4d18d92
Compare
julia-zack
force-pushed
the
register_fundtx_change
branch
3 times, most recently
from
3d4d58a
to
e5cce24
Compare
julia-zack
changed the base branch from
add_method_to_check_svp_period
to
recreate_valid_block_stored_chain
julia-zack
changed the base branch from
recreate_valid_block_stored_chain
to
add_method_to_check_svp_period
julia-zack
force-pushed
the
register_fundtx_change
branch
from
2f80201
to
9be77e9
Compare
julia-zack
force-pushed
the
add_method_to_check_svp_period
branch
from
4d18d92
to
f84b459
Compare
julia-zack
force-pushed
the
register_fundtx_change
branch
from
9be77e9
to
0b60713
Compare
julia-zack
force-pushed
the
add_method_to_check_svp_period
branch
2 times, most recently
from
ec70cd5
to
9e90491
Compare
Base automatically changed from
add_method_to_check_svp_period
to
feature/powpeg_validation_protocol-phase2
September 12, 2024 19:25
julia-zack
force-pushed
the
register_fundtx_change
branch
from
66acf35
to
24ec5c2
Compare
julia-zack
force-pushed
the
register_fundtx_change
branch
from
18f5cb9
to
56119ab
Compare
apancorb
reviewed
Sep 13, 2024
apancorb
approved these changes
Sep 16, 2024
| return svpFundTransaction; | ||
| } | ||
|
|
||
| private BtcTransaction createAndSavePegout() { |
There was a problem hiding this comment.
Out of curiosity, for these private utility methods, are we sure they dont already exist? Or something similar?
There was a problem hiding this comment.
I checked and didn't found anything!
There was a problem hiding this comment.
All transactions creation are done manually
julia-zack
force-pushed
the
register_fundtx_change
branch
from
6a3fd9f
to
a6e294a
Compare
julia-zack
changed the base branch from
feature/powpeg_validation_protocol-phase2
to
save_fund_tx_signed_instead_of_hash
julia-zack
force-pushed
the
register_fundtx_change
branch
from
a6e294a
to
8256285
Compare
|
julia-zack
force-pushed
the
save_fund_tx_signed_instead_of_hash
branch
3 times, most recently
from
14712e3
to
45b96c4
Compare
marcos-iov
changed the base branch from
save_fund_tx_signed_instead_of_hash
to
feature/powpeg_validation_protocol-phase2
marcos-iov
changed the base branch from
feature/powpeg_validation_protocol-phase2
to
save_fund_tx_signed_instead_of_hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Since the fund transaction will be treated as a pegout, its change will eventually be attempted to be registered through existing
registerBtcTransactionmethod.When that happen, and after recognizing and processing it as a pegout, we have to save its hash (now signed) in the corresponding storage entry, that meaning we have to add some extra checks to recognize this special transaction.
So, if validation process is ongoing, we will check if the received transaction is the fund transaction.
We say that the validation process is ongoing if: proposedFederation exists, and validation period is not ended, i.e., currentRskBlock < proposedFederationCreationBlockNumber + svpPeriodDuration
.
IN THIS PR
This pr creates a new private method,
processSvpFundTransactionHashSigned, that:svpFundTransactionSignedHashstorage entry, and the value saved in svpFundTransactionUnsignedHash storage entry is removed