Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev api docs fix param for getbalance example script #107

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Dev api docs fix param for getbalance example script #107

merged 3 commits into from
Oct 3, 2024

Conversation

RedVelvetZip
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024

@RedVelvetZip is attempting to deploy a commit to the IOV Labs Team on Vercel.

A member of the Team first needs to authorize it.

@RedVelvetZip RedVelvetZip mentioned this pull request Sep 5, 2024
Open
@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devportal-rootstock ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:55am

@owans owans requested a review from ivegabr September 13, 2024 10:36
@owans
Copy link
Collaborator

owans commented Sep 13, 2024 •
edited
Loading

Thank you for submitting this PR @RedVelvetZip.

@ivegabr Please review and approve this change. Thank you.

ivegabr
ivegabr approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ivegabr ivegabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ivegabr ivegabr linked an issue Sep 13, 2024 that may be closed by this pull request
getBalance script example 1 has the wrong input param #106
Closed
ivegabr
ivegabr approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@ivegabr ivegabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

ivegabr
ivegabr approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@ivegabr ivegabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@owans
Copy link
Collaborator

owans commented Oct 3, 2024

Thank you @RedVelvetZip for submitting this fix.

owans
owans approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@owans owans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owans owans merged commit f271512 into rsksmart:main Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivegabr ivegabr ivegabr approved these changes

@owans owans owans approved these changes

Assignees

@RedVelvetZip RedVelvetZip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getBalance script example 1 has the wrong input param
3 participants
@RedVelvetZip @owans @ivegabr