Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change getBalance script example input param from blockTag to blockNumber #1051

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RedVelvetZip
Copy link

What

  • In the first of three example scripts for the getBalance API query, change the input param from a blockTag to a blockNumber

Why

  • Script example 1 claims to use a blockNumber for the second param, while example 2 claims to use a blockHash and example 3 claims to use a blockTag. Script examples 2 and 3 correctly use the params they claim to, but example 1 erroneously had a blockTag instead of a blockHash

Refs

  • n/a

Copy link

vercel bot commented Sep 4, 2024

@RedVelvetZip is attempting to deploy a commit to the IOV Labs Team on Vercel.

A member of the Team first needs to authorize it.

@owans
Copy link
Collaborator

owans commented Sep 5, 2024

Hi @RedVelvetZip,

Thank you for submitting this PR.

This repo is no longer in active use, the new portal is now located at this repo: https://github.com/rsksmart/devportal.

Please move the changes to that one, and I will review.

Also interested to know what your thoughts are on the old docs and the newly revamped docs. Kindly submit a feedback using the rating tool on the new site: dev.rootstock.io or send us feedback here to qualify for the devportal raffle: https://share.hsforms.com/1ZWsORkYOTGeGvbyJ4PeFhg1noi4.

@RedVelvetZip
Copy link
Author

thanks @owans created a new PR here rsksmart/devportal#107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants