Update Yarn and Node #152
Update Yarn and Node #152
Conversation
| @@ -0,0 +1,4 @@ | |||
| /.yarn/** linguist-vendored | |||
There was a problem hiding this comment.
Yarn does this automatically when migrating from Yarn 1.x. I think this is meant to be used by GitHub for language statistics (https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github)
| "description": "Successor to Sun Card - Visualize the position of the sun over the horizon", | ||
| "type": "commonjs", | ||
| "main": "dist/index.js", | ||
| "scripts": { | ||
| "dev": "rollup -c rollup.config.dev.mjs --watch", | ||
| "build": "rimraf dist && yarn lint && yarn rollup", | ||
| "build": "rm -fr dist && yarn lint && yarn rollup", |
There was a problem hiding this comment.
Modern yarn has its own shell, to guarantee that things like rm -fr works the same across all platforms, including Windows.
I'm happy to update this lib and bring it to modern standards :) This PR is still in draft because I broke many tests, I'd like to fix them before merging it.
Sure! |
scinos
force-pushed
the
update-yarn-node
branch
from
8eff6ab
to
facee64
Compare
|
PR ready for review (ping @ThomDietrich). I managed to update Yarn + Node without having to change ESLint or Typescript, so this PR is now smaller than it was when I initially open it. I can't see CI results until this PR is approved, but locally everything seems to work:
|
|
Thanks! I've merged the PR to have a baseline CI response. The Build and Release job errors out with "Run actions/cache@v1: Error: Input required and not supplied: path" |
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
This PRs updates Yarn to a non-deprecated versions, and Node to the latest LTS version. This should make development
easier as we can use Yarn from Node's corepack, no need to try complex methods to install Yarn 1.x
Type of Change