Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use corrent Node and Yarn version in PR workflow #154

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

scinos
Copy link
Collaborator

@scinos scinos commented Nov 5, 2024

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

Fixes the CI errors introduced in #152

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

Additional Details

The fix consist in a few changes:

  • Update actions/setup-node to latest version.
  • Use native support for caching in actions/setup-node so we don't to deal with the cache ourselves.
  • Be sure it uses Node version from .nvmrc.
  • Enable corepack, so we pick yarn version from package.json.

Tested locally with act, seems to work fine. Will keep an eye on GH Actions results once this get approved.

Copy link

@ThomDietrich ThomDietrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ThomDietrich ThomDietrich merged commit d03367a into rejuvenate:main Nov 5, 2024
3 of 5 checks passed
@ThomDietrich
Copy link

Hey @scinos I went ahead and copied these changes to the releases workflow.

@scinos scinos deleted the fix-ci branch November 6, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants