Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1310: [release-4.18] osd: add tunefastdeviceclass: true for all ssd disk #2964

Merged
merged 1 commit into from
Jan 14, 2025
Merged

DFBUGS-1310: [release-4.18] osd: add tunefastdeviceclass: true for all ssd disk #2964

merged 1 commit into from
Jan 14, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2963

/assign parth-gr

@parth-gr
osd: add tunefastdeviceclass: true for all ssd disk
f88171a 
with exandstorage ux-backend handler we will be
ading ssd disk always,
So by default make the deviceSet spec, `deviceType: ssd`

Signed-off-by: parth-gr <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2025
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: parth-gr.

Note that only red-hat-storage members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2963

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member

/assign @malayparida2000 @iamniting

@iamniting
Copy link
Member

@parth-gr pls attach bug.

@parth-gr
Copy link
Member

parth-gr commented Jan 11, 2025 •
edited by openshift-ci bot
Loading

/retitle DFBUGS-1310: [release-4.18] osd: add tunefastdeviceclass: true for all ssd disk

@openshift-ci openshift-ci bot changed the title [release-4.18] osd: add tunefastdeviceclass: true for all ssd disk DFBUGS-1310: [release-4.18] osd: add tunefastdeviceclass: true for all ssd disk Jan 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2963

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

Done

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iamniting
Copy link
Member

@parth-gr Pls sort the jira acks

@parth-gr
Copy link
Member

@iamniting I have already given the dev ack, and the jira has the QA ack

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is invalid:

  • expected the bug to target the "odf-4.18" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Jan 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 13, 2025 •
edited by openshift-ci bot
Loading

@parth-gr: This pull request references [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@parth-gr
Copy link
Member

@iamniting @malayparida2000 ready to merge

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8e6ee17 into red-hat-storage:release-4.18 Jan 14, 2025
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 14, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: [Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1310](https://issues.redhat.com//browse/DFBUGS-1310) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2963

/assign parth-gr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamniting iamniting iamniting approved these changes

Assignees

@iamniting iamniting

@malayparida2000 malayparida2000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @parth-gr @iamniting @openshift-ci-robot @malayparida2000